Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add missing plugins to e2e studio #7981

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Dec 9, 2024

Description

#7502 & #7475 broke the e2e test suite because the e2e Studio is importing the schema types from the test-studio but those PRs didn't add the required plugins to the e2e Studio config.

What to review

If CI is happy we should be good

Notes for release

n/a

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:14am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:14am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:14am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:14am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 9, 2024 11:14am

Copy link
Contributor

github-actions bot commented Dec 9, 2024

No changes to documentation

@bjoerge bjoerge marked this pull request as ready for review December 9, 2024 11:12
@bjoerge bjoerge requested a review from a team as a code owner December 9, 2024 11:12
@bjoerge bjoerge requested review from RitaDias and removed request for a team December 9, 2024 11:12
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Component Testing Report Updated Dec 9, 2024 11:16 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 55s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 52s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 46s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 56s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Mon, 09 Dec 2024 11:59:21 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.9 efps (53ms) 19.6 efps (51ms) -2ms (-3.8%)
article (body) 48.4 efps (21ms) 52.9 efps (19ms) -2ms (-8.5%)
article (string inside object) 21.7 efps (46ms) 21.3 efps (47ms) +1ms (+2.2%)
article (string inside array) 19.2 efps (52ms) 18.9 efps (53ms) +1ms (+1.9%)
recipe (name) 46.5 efps (22ms) 45.5 efps (22ms) +1ms (+2.3%)
recipe (description) 55.6 efps (18ms) 54.1 efps (19ms) +1ms (+2.8%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 18.5 efps (54ms) +2ms (+3.8%)
synthetic (string inside object) 17.9 efps (56ms) 18.3 efps (55ms) -2ms (-2.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 53ms 60ms 67ms 141ms 326ms 12.7s
article (body) 21ms 26ms 40ms 156ms 382ms 6.5s
article (string inside object) 46ms 52ms 59ms 298ms 411ms 8.0s
article (string inside array) 52ms 56ms 66ms 169ms 522ms 8.5s
recipe (name) 22ms 26ms 31ms 46ms 0ms 7.6s
recipe (description) 18ms 20ms 26ms 38ms 0ms 4.7s
recipe (instructions) 7ms 9ms 9ms 11ms 0ms 3.2s
synthetic (title) 52ms 55ms 70ms 127ms 629ms 14.1s
synthetic (string inside object) 56ms 62ms 91ms 542ms 1522ms 9.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 51ms 57ms 73ms 253ms 238ms 12.6s
article (body) 19ms 22ms 28ms 197ms 226ms 6.1s
article (string inside object) 47ms 50ms 57ms 118ms 206ms 7.6s
article (string inside array) 53ms 58ms 68ms 297ms 400ms 8.2s
recipe (name) 22ms 24ms 28ms 42ms 0ms 7.2s
recipe (description) 19ms 20ms 22ms 28ms 0ms 4.7s
recipe (instructions) 7ms 9ms 10ms 12ms 0ms 3.4s
synthetic (title) 54ms 56ms 65ms 153ms 658ms 13.4s
synthetic (string inside object) 55ms 56ms 60ms 71ms 208ms 7.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Dec 9, 2024
Merged via the queue into next with commit e078ebc Dec 9, 2024
59 checks passed
@bjoerge bjoerge deleted the add-missing-plugins-to-e2e-studio branch December 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants