Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: showing documents in archived and published releases #7994

Merged
merged 12 commits into from
Dec 11, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Dec 9, 2024

Description

archivedView
For an archived release can view version documents; clicking through will show the historical version document and a temporary archived release chip


publishedView
For a published release can view version documents; clicking through will show the historical version document within the published perspective

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:18pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:18pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:18pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 1:18pm

Copy link
Contributor

github-actions bot commented Dec 9, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Component Testing Report Updated Dec 11, 2024 1:11 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 2s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 7s 11 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Wed, 11 Dec 2024 13:12:36 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
recipe (name) 40.8 efps (25ms) 27.8 efps (36ms) +12ms (+46.9%) 🔴
recipe (description) 45.5 efps (22ms) 30.3 efps (33ms) +11ms (+50.0%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (9ms) +2ms (-/-%)
synthetic (title) 16.4 efps (61ms) 7.2 efps (140ms) +79ms (+128.7%) 🔴
synthetic (string inside object) 18.5 efps (54ms) 7.1 efps (140ms) +86ms (+159.3%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 25ms 26ms 31ms 60ms 0ms 8.9s
recipe (description) 22ms 23ms 28ms 46ms 0ms 5.1s
recipe (instructions) 7ms 10ms 11ms 38ms 0ms 3.6s
synthetic (title) 61ms 64ms 74ms 152ms 929ms 14.6s
synthetic (string inside object) 54ms 59ms 69ms 549ms 526ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 36ms 38ms 43ms 71ms 10ms 9.7s
recipe (description) 33ms 35ms 39ms 55ms 21ms 6.3s
recipe (instructions) 9ms 11ms 12ms 25ms 9ms 3.5s
synthetic (title) 140ms 159ms 192ms 849ms 7032ms 21.7s
synthetic (string inside object) 140ms 147ms 163ms 880ms 6852ms 17.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @jordanl17!

@jordanl17 jordanl17 merged commit 63b2792 into corel Dec 11, 2024
53 of 56 checks passed
@jordanl17 jordanl17 deleted the corel-261-view-published-archived branch December 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants