Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): corel publish 2 action - test #8015

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Dec 11, 2024

Description

Adds a second publish action using the new action sanity.action.release.publish2. which is being developed.

To enable it, you need to add publish2: true in local storage

Screenshot 2024-12-11 at 17 12 58

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner December 11, 2024 16:03
@pedrobonamin pedrobonamin requested review from rexxars and removed request for a team December 11, 2024 16:03
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:32pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:32pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 4:32pm

Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin requested review from bjoerge and removed request for rexxars December 11, 2024 16:13
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Component Testing Report Updated Dec 11, 2024 4:24 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 52s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 7s 11 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 11, 2024

⚡️ Editor Performance Report

Updated Wed, 11 Dec 2024 16:25:12 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 21.3 efps (47ms) 17.2 efps (58ms) +11ms (+23.4%) 🔴
article (body) 56.2 efps (18ms) 45.9 efps (22ms) +4ms (+22.5%) 🔴
article (string inside object) 22.5 efps (45ms) 18.2 efps (55ms) +11ms (+23.6%) 🔴
article (string inside array) 19.6 efps (51ms) 16.4 efps (61ms) +10ms (+19.6%)
recipe (name) 41.7 efps (24ms) 28.6 efps (35ms) +11ms (+45.8%) 🔴
recipe (description) 47.6 efps (21ms) 29.4 efps (34ms) +13ms (+61.9%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 18.2 efps (55ms) 7.1 efps (140ms) +85ms (+154.5%) 🔴
synthetic (string inside object) 19.6 efps (51ms) 7.5 efps (133ms) +82ms (+160.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 47ms 55ms 68ms 241ms 221ms 12.9s
article (body) 18ms 20ms 26ms 141ms 427ms 6.5s
article (string inside object) 45ms 49ms 55ms 239ms 153ms 7.6s
article (string inside array) 51ms 56ms 62ms 375ms 460ms 8.3s
recipe (name) 24ms 26ms 29ms 77ms 0ms 7.9s
recipe (description) 21ms 22ms 24ms 43ms 0ms 4.9s
recipe (instructions) 6ms 8ms 9ms 21ms 0ms 3.3s
synthetic (title) 55ms 58ms 71ms 133ms 785ms 14.8s
synthetic (string inside object) 51ms 52ms 55ms 469ms 218ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 60ms 73ms 254ms 874ms 13.9s
article (body) 22ms 26ms 44ms 263ms 413ms 7.0s
article (string inside object) 55ms 59ms 67ms 254ms 893ms 8.7s
article (string inside array) 61ms 67ms 80ms 117ms 1283ms 9.1s
recipe (name) 35ms 38ms 43ms 55ms 11ms 9.6s
recipe (description) 34ms 35ms 39ms 50ms 9ms 6.2s
recipe (instructions) 7ms 9ms 10ms 23ms 7ms 3.4s
synthetic (title) 140ms 147ms 158ms 758ms 6884ms 22.9s
synthetic (string inside object) 133ms 141ms 147ms 697ms 5983ms 16.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you @pedrobonamin

@pedrobonamin pedrobonamin merged commit f991463 into corel Dec 11, 2024
56 of 57 checks passed
@pedrobonamin pedrobonamin deleted the add-publish-2-action branch December 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants