fix(Presence): replace unsafe ref access during render

[stipsan]

Description

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:46pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:46pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:46pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:46pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 13, 2024 6:46pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Dec 13, 2024 6:36 PM (UTC)

❌ Failed Tests (7) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	41s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	56s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	4m 28s	0	0	6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 4s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	❌ Failed (Inspect)	2m 27s	17	0	1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	42s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 52s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 18:38:46 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	23.8 efps (42ms)	25.0 efps (40ms)	-2ms (-4.8%)	✅
article (body)	67.3 efps (15ms)	63.9 efps (16ms)	+1ms (-/-%)	✅
article (string inside object)	25.0 efps (40ms)	24.4 efps (41ms)	+1ms (+2.5%)	✅
article (string inside array)	23.0 efps (44ms)	22.2 efps (45ms)	+2ms (+3.4%)	✅
recipe (name)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	58.8 efps (17ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	19.2 efps (52ms)	19.6 efps (51ms)	-1ms (-1.9%)	✅
synthetic (string inside object)	19.6 efps (51ms)	18.9 efps (53ms)	+2ms (+3.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	42ms	45ms	50ms	104ms	178ms	10.8s
article (body)	15ms	18ms	40ms	164ms	221ms	5.3s
article (string inside object)	40ms	44ms	60ms	95ms	211ms	7.1s
article (string inside array)	44ms	45ms	49ms	76ms	133ms	7.0s
recipe (name)	19ms	21ms	24ms	39ms	0ms	7.1s
recipe (description)	17ms	18ms	20ms	30ms	0ms	4.4s
recipe (instructions)	5ms	7ms	8ms	16ms	0ms	3.1s
synthetic (title)	52ms	54ms	58ms	83ms	156ms	14.2s
synthetic (string inside object)	51ms	53ms	64ms	470ms	850ms	8.2s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	40ms	42ms	63ms	96ms	171ms	11.4s
article (body)	16ms	19ms	23ms	91ms	234ms	5.5s
article (string inside object)	41ms	44ms	51ms	178ms	143ms	7.0s
article (string inside array)	45ms	49ms	58ms	90ms	392ms	7.5s
recipe (name)	19ms	21ms	22ms	32ms	0ms	7.6s
recipe (description)	17ms	19ms	23ms	60ms	0ms	4.7s
recipe (instructions)	5ms	7ms	8ms	21ms	0ms	3.1s
synthetic (title)	51ms	56ms	76ms	104ms	566ms	13.8s
synthetic (string inside object)	53ms	58ms	68ms	343ms	523ms	8.3s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.

[stipsan]

Replaced by #8077