Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve WorkspaceRouterProvider perf #8057

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Dec 13, 2024

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:38am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 11:38am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Component Testing Report Updated Dec 18, 2024 11:35 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 20s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 47s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 52s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 13, 2024

⚡️ Editor Performance Report

Updated Wed, 18 Dec 2024 11:36:12 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 26.3 efps (38ms) -1ms (-2.6%)
article (body) 67.1 efps (15ms) 72.5 efps (14ms) -1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.6 efps (39ms) +1ms (+2.6%)
article (string inside array) 23.8 efps (42ms) 23.8 efps (42ms) +0ms (-/-%)
recipe (name) 50.0 efps (20ms) 52.6 efps (19ms) -1ms (-5.0%)
recipe (description) 55.6 efps (18ms) 62.5 efps (16ms) -2ms (-11.1%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%)
synthetic (title) 19.4 efps (52ms) 19.6 efps (51ms) -1ms (-1.0%)
synthetic (string inside object) 19.8 efps (51ms) 20.4 efps (49ms) -2ms (-3.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 43ms 53ms 174ms 516ms 9.8s
article (body) 15ms 17ms 22ms 80ms 242ms 5.6s
article (string inside object) 38ms 41ms 51ms 251ms 248ms 6.9s
article (string inside array) 42ms 45ms 50ms 171ms 130ms 7.2s
recipe (name) 20ms 22ms 27ms 40ms 0ms 7.4s
recipe (description) 18ms 20ms 22ms 30ms 0ms 4.5s
recipe (instructions) 5ms 6ms 7ms 11ms 0ms 3.0s
synthetic (title) 52ms 55ms 60ms 117ms 586ms 13.6s
synthetic (string inside object) 51ms 57ms 73ms 397ms 704ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 44ms 49ms 441ms 165ms 11.4s
article (body) 14ms 16ms 22ms 176ms 201ms 5.2s
article (string inside object) 39ms 41ms 49ms 166ms 140ms 6.7s
article (string inside array) 42ms 46ms 51ms 177ms 147ms 7.0s
recipe (name) 19ms 20ms 27ms 42ms 0ms 7.6s
recipe (description) 16ms 18ms 20ms 37ms 0ms 4.4s
recipe (instructions) 6ms 8ms 9ms 16ms 0ms 3.1s
synthetic (title) 51ms 56ms 60ms 285ms 505ms 12.9s
synthetic (string inside object) 49ms 54ms 65ms 466ms 787ms 8.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant