chore: add follow up comments on million lint

[stipsan]

Follows up on code review comments by @bjoerge in #8032 :)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 4:00pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 4:00pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 4:00pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 16, 2024 4:00pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 16, 2024 4:00pm

[github-actions]

No changes to documentation

[github-actions]

⚡️ Editor Performance Report

Updated Mon, 16 Dec 2024 15:38:46 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	22.2 efps (45ms)	22.2 efps (45ms)	+0ms (-/-%)	✅
article (body)	67.1 efps (15ms)	67.6 efps (15ms)	-0ms (-/-%)	✅
article (string inside object)	23.8 efps (42ms)	26.3 efps (38ms)	-4ms (-9.5%)	✅
article (string inside array)	21.3 efps (47ms)	21.3 efps (47ms)	+0ms (-/-%)	✅
recipe (name)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	58.8 efps (17ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	18.2 efps (55ms)	19.4 efps (52ms)	-4ms (-6.4%)	✅
synthetic (string inside object)	18.2 efps (55ms)	18.9 efps (53ms)	-2ms (-3.6%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	45ms	48ms	71ms	415ms	615ms	10.7s
article (body)	15ms	16ms	21ms	166ms	201ms	5.3s
article (string inside object)	42ms	44ms	46ms	68ms	146ms	6.8s
article (string inside array)	47ms	49ms	52ms	122ms	10ms	7.2s
recipe (name)	19ms	20ms	22ms	42ms	0ms	7.5s
recipe (description)	17ms	18ms	20ms	22ms	0ms	4.4s
recipe (instructions)	5ms	7ms	8ms	9ms	0ms	3.1s
synthetic (title)	55ms	59ms	69ms	318ms	847ms	14.1s
synthetic (string inside object)	55ms	58ms	64ms	77ms	330ms	7.7s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	45ms	47ms	49ms	52ms	22ms	12.0s
article (body)	15ms	16ms	17ms	72ms	53ms	4.8s
article (string inside object)	38ms	40ms	41ms	43ms	0ms	6.2s
article (string inside array)	47ms	49ms	53ms	175ms	160ms	7.2s
recipe (name)	19ms	21ms	25ms	38ms	0ms	7.0s
recipe (description)	17ms	19ms	21ms	34ms	0ms	4.5s
recipe (instructions)	5ms	8ms	8ms	9ms	0ms	3.3s
synthetic (title)	52ms	54ms	59ms	296ms	528ms	17.3s
synthetic (string inside object)	53ms	56ms	61ms	83ms	859ms	8.0s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.

[github-actions]

Component Testing Report Updated Dec 16, 2024 3:46 PM (UTC)

❌ Failed Tests (3) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 11s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	41s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	57s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	28s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	1m 48s	4	0	2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 13s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 6s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 49s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	42s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	2m 33s	20	0	1
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0