Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use consistent framer-motion semver range #8094

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: use consistent framer-motion semver range #8094

merged 1 commit into from
Dec 18, 2024
+2 −2

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Dec 18, 2024

Description

Uses the same semver range as in @sanity/presentation and @sanity/ui.
It ensures that once framer-motion v11.16 and later comes out we won't have duplicate versions of framer-motion being loaded up.

What to review

Should make sense?

Testing

Existing tests enough.

Notes for release

Probably unnecessary since we just bumped framer-motion for react 19 support, unless we publish a studio release of that before merging this PR 🤔

@stipsan stipsan requested a review from a team as a code owner December 18, 2024 10:44
@stipsan stipsan requested review from rexxars and removed request for a team December 18, 2024 10:44
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:56am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:56am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:56am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 18, 2024 10:56am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Dec 18, 2024 10:54 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 47s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 52s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 18 Dec 2024 10:56:34 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 24.7 efps (41ms) 23.3 efps (43ms) +3ms (+6.2%) ✅
article (body) 58.0 efps (17ms) 62.9 efps (16ms) -1ms (-7.8%) ✅
article (string inside object) 23.3 efps (43ms) 23.3 efps (43ms) +0ms (-/-%) ✅
article (string inside array) 20.8 efps (48ms) 21.7 efps (46ms) -2ms (-4.2%) ✅
recipe (name) 48.8 efps (21ms) 50.0 efps (20ms) -1ms (-2.4%) ✅
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%) ✅
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (6ms) +1ms (-/-%) ✅
synthetic (title) 20.0 efps (50ms) 19.6 efps (51ms) +1ms (+2.0%) ✅
synthetic (string inside object) 19.6 efps (51ms) 19.6 efps (51ms) +0ms (-/-%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 43ms 48ms 363ms 236ms 11.0s
article (body) 17ms 19ms 73ms 116ms 252ms 6.1s
article (string inside object) 43ms 46ms 59ms 203ms 146ms 7.2s
article (string inside array) 48ms 50ms 54ms 171ms 146ms 7.6s
recipe (name) 21ms 22ms 24ms 56ms 0ms 7.6s
recipe (description) 18ms 19ms 20ms 30ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 14ms 0ms 3.1s
synthetic (title) 50ms 52ms 55ms 247ms 487ms 14.3s
synthetic (string inside object) 51ms 54ms 63ms 372ms 742ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 54ms 83ms 503ms 835ms 11.8s
article (body) 16ms 18ms 37ms 141ms 83ms 5.2s
article (string inside object) 43ms 46ms 50ms 244ms 380ms 7.6s
article (string inside array) 46ms 48ms 53ms 164ms 174ms 7.3s
recipe (name) 20ms 21ms 23ms 43ms 0ms 7.5s
recipe (description) 17ms 19ms 21ms 40ms 0ms 4.5s
recipe (instructions) 6ms 7ms 8ms 14ms 0ms 3.1s
synthetic (title) 51ms 54ms 60ms 287ms 545ms 13.5s
synthetic (string inside object) 51ms 57ms 72ms 143ms 935ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@stipsan stipsan enabled auto-merge December 18, 2024 11:03
@stipsan stipsan added this pull request to the merge queue Dec 18, 2024
Merged via the queue into next with commit 78529d6 Dec 18, 2024
58 checks passed
@stipsan stipsan deleted the use-consistent-framer-motion-semver-range branch December 18, 2024 16:10
bjoerge added a commit that referenced this pull request Dec 19, 2024
@bjoerge
Merge branch 'next' into corel
1adb6e3 
* next: (68 commits)
  fix(deps): update dependency @sanity/icons to ^3.5.5 (#8105)
  fix(deps): update dependency @sanity/ui to ^2.10.12 (#8108)
  fix(deps): update dependency react-rx to ^4.1.10 (#8109)
  chore(deps): update dependency @sanity/tsdoc to v1.0.153 (#8107)
  chore(deps): update typescript-tooling (#8104)
  fix(deps): update dependency @sanity/icons to ^3.5.5 (#8106)
  feat(typegen): add support for astro (#8098)
  chore(deps): update dependency turbo to ^2.3.3 (#8099)
  fix(deps): Update dev-non-major (#8100)
  fix: `WebSocket is closed before the connection is established` warning (#8042)
  v3.68.1
  fix(deps): update dependency @sanity/presentation to v1.19.13 (#8102)
  v3.68.0
  fix: use consistent `framer-motion` semver range (#8094)
  refactor(core): replace `PortableTextEditor` with `EditorProvider` (#8040)
  fix: improve `SanityDefaultPreview` memoization (#8049)
  fix: tooltip position in announcements popup (#8092)
  fix: replace useMemo with useState (#8095)
  fix: replace unsafe `useMemo` with `useState` (#8047)
  fix: replace `React.createElement` with jsx runtime (#8043)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stipsan @rexxars