chore(cli): bump template validator #8115

RostiMelk · 2024-12-19T21:03:27Z

Description

Bumping @sanity/template-validator to latest version (v1.2.1)

This version includes some api changes, so I've adjusted bootstrapRemoteTemplate to account for that

What to review

Build the CLI and running npm link
Run sanity init --template sanity-io/sanity-template-nextjs-clean in your terminal.
Make sure template installs as expected

Notes for release

N/A

vercel · 2024-12-19T21:03:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 9:16pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 9:16pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 9:16pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 9:16pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Dec 19, 2024 9:16pm

RostiMelk · 2024-12-19T21:04:24Z

packages/@sanity/cli/src/util/remoteTemplate.ts

- * Supports pnpm workspaces, Lerna, Rush, and npm workspaces (package.json).
- * @returns Promise that resolves to an array of package paths/names if monorepo is detected, undefined otherwise
- */
-export async function getPackages(


All of these wrappers are no longer needed

socket-security · 2024-12-19T21:04:33Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@sanity/[email protected]	network Transitive: environment, filesystem, shell, unsafe	`+26`	13.7 MB	sanity-io

🚮 Removed packages: npm/@sanity/[email protected]

View full report↗︎

github-actions · 2024-12-19T21:07:25Z

No changes to documentation

github-actions · 2024-12-19T21:12:52Z

Component Testing Report Updated Dec 19, 2024 9:12 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 4s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	38s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	50s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	25s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	14s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 6s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 27s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 39s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	12s	3	9
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 42s	21	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-12-19T21:15:49Z

⚡️ Editor Performance Report

Updated Thu, 19 Dec 2024 21:15:49 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	21.3 efps (47ms)	22.7 efps (44ms)	-3ms (-6.4%)	✅
article (body)	68.0 efps (15ms)	61.7 efps (16ms)	+2ms (+10.2%)	✅
article (string inside object)	24.7 efps (41ms)	24.7 efps (41ms)	+0ms (-/-%)	✅
article (string inside array)	22.2 efps (45ms)	22.2 efps (45ms)	+0ms (-/-%)	✅
recipe (name)	52.6 efps (19ms)	55.6 efps (18ms)	-1ms (-5.3%)	✅
recipe (description)	57.1 efps (18ms)	60.6 efps (17ms)	-1ms (-5.7%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	18.5 efps (54ms)	19.4 efps (52ms)	-3ms (-4.6%)	✅
synthetic (string inside object)	19.2 efps (52ms)	20.0 efps (50ms)	-2ms (-3.8%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	47ms	73ms	90ms	630ms	1209ms	12.1s
article (body)	15ms	17ms	20ms	60ms	80ms	5.4s
article (string inside object)	41ms	44ms	50ms	235ms	244ms	7.3s
article (string inside array)	45ms	47ms	54ms	173ms	151ms	7.2s
recipe (name)	19ms	22ms	25ms	38ms	0ms	7.5s
recipe (description)	18ms	19ms	21ms	28ms	0ms	4.5s
recipe (instructions)	6ms	8ms	9ms	11ms	0ms	3.2s
synthetic (title)	54ms	56ms	58ms	102ms	319ms	12.8s
synthetic (string inside object)	52ms	57ms	60ms	495ms	824ms	8.5s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	44ms	67ms	79ms	521ms	805ms	11.0s
article (body)	16ms	18ms	20ms	58ms	102ms	5.3s
article (string inside object)	41ms	43ms	50ms	241ms	251ms	7.0s
article (string inside array)	45ms	48ms	53ms	196ms	151ms	7.3s
recipe (name)	18ms	20ms	23ms	37ms	0ms	7.5s
recipe (description)	17ms	17ms	18ms	28ms	0ms	4.3s
recipe (instructions)	6ms	8ms	9ms	11ms	0ms	3.2s
synthetic (title)	52ms	54ms	59ms	297ms	542ms	12.7s
synthetic (string inside object)	50ms	54ms	64ms	481ms	827ms	8.3s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

chore: bump template validator

6b4316f

RostiMelk requested a review from a team as a code owner December 19, 2024 21:03

RostiMelk requested review from ricokahler and removed request for a team December 19, 2024 21:03

RostiMelk commented Dec 19, 2024

View reviewed changes

ricokahler approved these changes Dec 19, 2024

View reviewed changes

vercel bot deployed to Preview – page-building-studio December 19, 2024 21:07 View deployment

vercel bot deployed to Preview – performance-studio December 19, 2024 21:07 View deployment

vercel bot deployed to Preview – test-studio December 19, 2024 21:08 View deployment

vercel bot deployed to Preview – test-next-studio December 19, 2024 21:16 View deployment

RostiMelk added this pull request to the merge queue Dec 19, 2024

Merged via the queue into next with commit 4afd104 Dec 19, 2024
57 checks passed

RostiMelk deleted the feat/cli/upgrade-validator branch December 19, 2024 21:17

bjoerge pushed a commit that referenced this pull request Dec 20, 2024

chore(cli): bump template validator (#8115)

5521f87

binoy14 pushed a commit that referenced this pull request Dec 20, 2024

chore(cli): bump template validator (#8115)

e39c5b2

RostiMelk mentioned this pull request Dec 22, 2024

fix(cli): pin template validator version #8131

Closed

krijoh92 pushed a commit to krijoh92/sanity that referenced this pull request Dec 25, 2024

chore(cli): bump template validator (sanity-io#8115)

2f2e22a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(cli): bump template validator #8115

chore(cli): bump template validator #8115

RostiMelk commented Dec 19, 2024

vercel bot commented Dec 19, 2024 •

edited

Loading

RostiMelk Dec 19, 2024

socket-security bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

chore(cli): bump template validator #8115

chore(cli): bump template validator #8115

Conversation

RostiMelk commented Dec 19, 2024

Description

What to review

Notes for release

vercel bot commented Dec 19, 2024 • edited Loading

RostiMelk Dec 19, 2024

Choose a reason for hiding this comment

socket-security bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

vercel bot commented Dec 19, 2024 •

edited

Loading