-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(releases): fixing issues with virtual list and releases overview and summary tests #8123
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
799e942
to
cdb12bb
Compare
No changes to documentation |
⚡️ Editor Performance ReportUpdated Fri, 20 Dec 2024 16:07:51 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
Component Testing Report Updated Dec 20, 2024 2:30 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, that's some really amazing detective work @jordanl17! Great call extracting this into a shared util as well <3
Description
With Tanstack Virtual being upgraded in Next, this introduces issues in testing environments where the size of virtual list items is 0px, resulting in none of them being rendered (failing tests).
The workaround is already present in next, but has been abstracted into a function as it's quite likely this will need to be used in other places as there's no clear sign this will be rectified.
This also necessitated some changes to the testing harnesses for
RealeasesOverview
andReleaseSummary
to ensure the virtual list isn't rendered until the exact sized parent is first.What to review
Testing
Tests updated and all now pass on COREL
Notes for release
N/A