feat(cli): add unattended mode flag to sanity undeploy
#8130
+61
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@nkgentile is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
nkgentile
force-pushed
the
feature/add-unattended-mode-for-undeploy
branch
from
d5c39c8 to
84431a2
Compare
nkgentile
changed the title
sanity undeploysanity undeploy
jordanl17
reviewed
Dec 23, 2024
| */ | ||
| const unattendedMode = Boolean(flags.yes || flags.y) | ||
|
|
||
| // If it is in unattended mode, we don't want to prompt |
There was a problem hiding this comment.
Q: is this comment incorrect, should it be If it is NOT in unattended mode..., or have I misunderstood the logic?
There was a problem hiding this comment.
I think it's correct. I copied the wording and logic from here:
https://github.com/sanity-io/sanity/blob/ddb65fa21a42856926331635e63b17ac420d529a/packages/sanity/src/_internal/cli/actions/build/buildAction.ts#L76C1-L77C1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--yes(or-y) flag to theundeploycommand, enabling unattended mode:This flag is particularly useful for CI/CD workflows, such as deploying a feature branch of a Sanity Studio and automatically undeploying it when the corresponding pull request is closed.
What to review
Testing
Notes for release
Updating documentation to include new flag. The help docs for the command have been updated with an example.