Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing deprecated motion for motion.create #8145

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 5:06pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 5:06pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 5:06pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 5:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 27, 2024 5:06pm

@jordanl17 jordanl17 marked this pull request as ready for review December 27, 2024 16:52
@jordanl17 jordanl17 requested a review from a team as a code owner December 27, 2024 16:52
@jordanl17 jordanl17 requested review from cngonzalez and removed request for a team and cngonzalez December 27, 2024 16:52
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 27, 2024 5:02 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 2m 18s 17 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 27 Dec 2024 17:03:30 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 20.8 efps (48ms) +11ms (+29.7%) 🔴
article (body) 78.1 efps (13ms) 73.0 efps (14ms) +1ms (-/-%)
article (string inside object) 28.2 efps (36ms) 20.8 efps (48ms) +13ms (+35.2%) 🔴
article (string inside array) 26.0 efps (39ms) 18.9 efps (53ms) +15ms (+37.7%) 🔴
synthetic (title) 20.0 efps (50ms) 7.9 efps (126ms) +76ms (+152.0%) 🔴
synthetic (string inside object) 20.4 efps (49ms) 8.1 efps (124ms) +75ms (+153.1%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 46ms 58ms 520ms 836ms 10.7s
article (body) 13ms 15ms 16ms 63ms 203ms 5.0s
article (string inside object) 36ms 39ms 56ms 74ms 234ms 6.6s
article (string inside array) 39ms 41ms 47ms 90ms 164ms 6.6s
synthetic (title) 50ms 52ms 54ms 82ms 204ms 12.4s
synthetic (string inside object) 49ms 53ms 67ms 546ms 822ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 48ms 52ms 61ms 367ms 584ms 12.1s
article (body) 14ms 15ms 20ms 197ms 307ms 5.1s
article (string inside object) 48ms 50ms 55ms 123ms 354ms 7.9s
article (string inside array) 53ms 58ms 70ms 226ms 778ms 8.3s
synthetic (title) 126ms 138ms 163ms 639ms 6469ms 20.4s
synthetic (string inside object) 124ms 134ms 159ms 840ms 5914ms 15.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 merged commit c784561 into corel Dec 27, 2024
53 of 56 checks passed
@jordanl17 jordanl17 deleted the corel-chore-motion-create branch December 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant