-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): replace 'sanity'
imports for relative paths in core
#8160
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Jan 2, 2025 2:52 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Thu, 02 Jan 2025 14:54:43 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Description
Adds a new rule to avoid imports from
sanity
in files insidepackages/src/core/**
and replaces all the necessary imports.Importing from
sanity
in core creates issues with the tests running withvitest
, mockingsanity
inside a test incore
generates inconsistent imports and could produce hard to follow tests errors.example:
What to review
Is this change correct?
Testing
No new functionalities added, existing tests passing should be enough
Notes for release
n/a this is internal