You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before you could not edit the strings for New {{ schemaType }} or Error: {{ schemaType }} but now you can.
What to review
Make sure there are no other places you can think of this happening that doesn't make sense and should also be changed.
Testing
I looked at the Translate.test.tsx to see if it was worth doing but it seems that the tests aren't covering specific translations but more that the core concepts of translation in the app are working. Therefore this doesn't seem needed.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
33ms
37ms
44ms
163ms
168ms
10.7s
article (body)
14ms
17ms
22ms
97ms
226ms
5.0s
article (string inside object)
36ms
41ms
51ms
202ms
134ms
6.7s
article (string inside array)
38ms
40ms
50ms
167ms
155ms
6.6s
recipe (name)
18ms
20ms
23ms
32ms
0ms
6.5s
recipe (description)
16ms
19ms
21ms
34ms
0ms
4.4s
recipe (instructions)
5ms
6ms
7ms
10ms
0ms
3.0s
synthetic (title)
56ms
59ms
69ms
291ms
666ms
12.7s
synthetic (string inside object)
54ms
62ms
72ms
484ms
1014ms
8.8s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
37ms
40ms
46ms
434ms
142ms
10.4s
article (body)
13ms
15ms
17ms
47ms
54ms
4.5s
article (string inside object)
36ms
37ms
39ms
110ms
135ms
6.4s
article (string inside array)
37ms
39ms
51ms
160ms
157ms
6.8s
recipe (name)
17ms
18ms
20ms
47ms
0ms
6.1s
recipe (description)
15ms
16ms
17ms
34ms
0ms
4.2s
recipe (instructions)
5ms
7ms
7ms
18ms
0ms
3.0s
synthetic (title)
54ms
58ms
61ms
360ms
713ms
12.8s
synthetic (string inside object)
52ms
57ms
74ms
459ms
990ms
8.4s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
You can read about the issue NRK is having here.
Before you could not edit the strings for
New {{ schemaType }}
orError: {{ schemaType }}
but now you can.What to review
Make sure there are no other places you can think of this happening that doesn't make sense and should also be changed.
Testing
I looked at the
Translate.test.tsx
to see if it was worth doing but it seems that the tests aren't covering specific translations but more that the core concepts of translation in the app are working. Therefore this doesn't seem needed.Notes for release
N/A