Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make header new and error text customisable #8162

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

EoinFalconer
Copy link
Contributor

Description

You can read about the issue NRK is having here.

Before you could not edit the strings for New {{ schemaType }} or Error: {{ schemaType }} but now you can.

What to review

Make sure there are no other places you can think of this happening that doesn't make sense and should also be changed.

Testing

I looked at the Translate.test.tsx to see if it was worth doing but it seems that the tests aren't covering specific translations but more that the core concepts of translation in the app are working. Therefore this doesn't seem needed.

Notes for release

N/A

@EoinFalconer EoinFalconer requested a review from a team as a code owner January 2, 2025 15:15
@EoinFalconer EoinFalconer requested review from ryanbonial and removed request for a team January 2, 2025 15:15
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:23pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:23pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:23pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 2, 2025 3:23pm

@EoinFalconer EoinFalconer requested review from pedrobonamin and removed request for ryanbonial January 2, 2025 15:15
Copy link
Contributor

github-actions bot commented Jan 2, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Component Testing Report Updated Jan 2, 2025 3:21 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 37s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 22s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 2, 2025

⚡️ Editor Performance Report

Updated Thu, 02 Jan 2025 15:27:08 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 30.3 efps (33ms) 27.0 efps (37ms) +4ms (+12.1%)
article (body) 72.5 efps (14ms) 77.8 efps (13ms) -1ms (-/-%)
article (string inside object) 27.8 efps (36ms) 27.8 efps (36ms) +0ms (-/-%)
article (string inside array) 26.3 efps (38ms) 27.4 efps (37ms) -2ms (-3.9%)
recipe (name) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (description) 62.5 efps (16ms) 66.7 efps (15ms) -1ms (-6.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 17.9 efps (56ms) 18.7 efps (54ms) -3ms (-4.5%)
synthetic (string inside object) 18.5 efps (54ms) 19.2 efps (52ms) -2ms (-3.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 33ms 37ms 44ms 163ms 168ms 10.7s
article (body) 14ms 17ms 22ms 97ms 226ms 5.0s
article (string inside object) 36ms 41ms 51ms 202ms 134ms 6.7s
article (string inside array) 38ms 40ms 50ms 167ms 155ms 6.6s
recipe (name) 18ms 20ms 23ms 32ms 0ms 6.5s
recipe (description) 16ms 19ms 21ms 34ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 10ms 0ms 3.0s
synthetic (title) 56ms 59ms 69ms 291ms 666ms 12.7s
synthetic (string inside object) 54ms 62ms 72ms 484ms 1014ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 40ms 46ms 434ms 142ms 10.4s
article (body) 13ms 15ms 17ms 47ms 54ms 4.5s
article (string inside object) 36ms 37ms 39ms 110ms 135ms 6.4s
article (string inside array) 37ms 39ms 51ms 160ms 157ms 6.8s
recipe (name) 17ms 18ms 20ms 47ms 0ms 6.1s
recipe (description) 15ms 16ms 17ms 34ms 0ms 4.2s
recipe (instructions) 5ms 7ms 7ms 18ms 0ms 3.0s
synthetic (title) 54ms 58ms 61ms 360ms 713ms 12.8s
synthetic (string inside object) 52ms 57ms 74ms 459ms 990ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@EoinFalconer EoinFalconer added this pull request to the merge queue Jan 2, 2025
Merged via the queue into next with commit 30cd307 Jan 2, 2025
57 checks passed
@EoinFalconer EoinFalconer deleted the fix/SAPP-21 branch January 2, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants