You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing credentials when adding CORS entry on remote template init. This is because some of the remote templates embeds a Studio, which requires your CORS entry to allow for credentials.
My initial idea was to somehow dynamically figure out if you need to allow for credentials, but given that we're only dealing with localhost entries here, I think it's fine to just hardcode it.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
35ms
39ms
84ms
200ms
321ms
10.8s
article (body)
19ms
22ms
34ms
265ms
361ms
5.7s
article (string inside object)
37ms
39ms
54ms
70ms
139ms
6.5s
article (string inside array)
40ms
42ms
48ms
159ms
142ms
6.7s
recipe (name)
19ms
21ms
22ms
42ms
0ms
8.1s
recipe (description)
17ms
19ms
21ms
36ms
0ms
4.4s
recipe (instructions)
6ms
7ms
10ms
22ms
0ms
3.1s
synthetic (title)
53ms
55ms
58ms
438ms
637ms
13.6s
synthetic (string inside object)
49ms
51ms
56ms
124ms
419ms
8.3s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
36ms
39ms
46ms
193ms
239ms
10.5s
article (body)
19ms
22ms
28ms
79ms
62ms
5.3s
article (string inside object)
35ms
37ms
42ms
158ms
133ms
6.2s
article (string inside array)
40ms
44ms
53ms
184ms
244ms
7.1s
recipe (name)
17ms
18ms
19ms
40ms
0ms
7.4s
recipe (description)
15ms
16ms
17ms
26ms
0ms
4.2s
recipe (instructions)
6ms
8ms
9ms
19ms
0ms
3.1s
synthetic (title)
51ms
54ms
61ms
149ms
567ms
13.0s
synthetic (string inside object)
50ms
51ms
66ms
494ms
961ms
8.8s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allowing credentials when adding CORS entry on remote template init. This is because some of the remote templates embeds a Studio, which requires your CORS entry to allow for credentials.
My initial idea was to somehow dynamically figure out if you need to allow for credentials, but given that we're only dealing with localhost entries here, I think it's fine to just hardcode it.
Testing
Run
Your project should have a CORS entry for localhost:3000 with credentials allowed
Notes for release
N/A