Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): bump @sanity/template-validator to latest (2.3.2) #8220

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

RostiMelk
Copy link
Member

@RostiMelk RostiMelk commented Jan 9, 2025

Description

bump @sanity/template-validator to latest (2.3.2)

This version includes some bug fixes related to the use of wildcards when defining packages in monorepos.

Testing

  1. Checkout to this branch
  2. cd packages/@sanity/cli
  3. pnpm install
  4. pnpm run build && npm link
  5. In a projects folder, run sanity init --template https://github.com/hrithikroboto/next-sanity-turbo

Notes for release

N/A

@RostiMelk RostiMelk requested a review from a team as a code owner January 9, 2025 09:48
@RostiMelk RostiMelk requested review from juice49 and removed request for a team January 9, 2025 09:48
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:55am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:55am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 10:55am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 10:55am
test-next-studio ⬜️ Ignored (Inspect) Jan 14, 2025 10:55am

Copy link
Contributor

github-actions bot commented Jan 9, 2025

No changes to documentation

Copy link

socket-security bot commented Jan 9, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] 🔁 npm/@sanity/[email protected] Transitive: environment, filesystem, shell, unsafe +25 13.7 MB armandocerna, ash, atombender, ...63 more

View full report↗︎

@RostiMelk RostiMelk changed the title chore/cli): bump @sanity/template-validator to latest (2.3.2) chore(cli): bump @sanity/template-validator to latest (2.3.2) Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Component Testing Report Updated Jan 14, 2025 11:01 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 9, 2025

⚡️ Editor Performance Report

Updated Tue, 14 Jan 2025 11:01:37 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 23.5 efps (43ms) +4ms (+9.0%)
article (body) 67.6 efps (15ms) 63.7 efps (16ms) +1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.6 efps (39ms) +1ms (+2.6%)
article (string inside array) 23.3 efps (43ms) 22.7 efps (44ms) +1ms (+2.3%)
recipe (name) 50.0 efps (20ms) 52.6 efps (19ms) -1ms (-5.0%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 19.6 efps (51ms) 19.6 efps (51ms) +0ms (-/-%)
synthetic (string inside object) 19.6 efps (51ms) 20.8 efps (48ms) -3ms (-5.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 41ms 46ms 412ms 236ms 10.7s
article (body) 15ms 17ms 20ms 162ms 230ms 5.8s
article (string inside object) 38ms 40ms 46ms 76ms 143ms 6.5s
article (string inside array) 43ms 46ms 52ms 180ms 297ms 7.0s
recipe (name) 20ms 21ms 24ms 39ms 2ms 7.2s
recipe (description) 17ms 18ms 22ms 31ms 0ms 4.4s
recipe (instructions) 6ms 7ms 9ms 25ms 0ms 3.2s
synthetic (title) 51ms 52ms 62ms 201ms 444ms 11.7s
synthetic (string inside object) 51ms 53ms 60ms 532ms 1171ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 64ms 67ms 395ms 718ms 10.9s
article (body) 16ms 17ms 27ms 187ms 208ms 5.6s
article (string inside object) 39ms 40ms 58ms 171ms 216ms 6.9s
article (string inside array) 44ms 46ms 55ms 104ms 288ms 7.2s
recipe (name) 19ms 21ms 24ms 65ms 0ms 7.2s
recipe (description) 17ms 18ms 20ms 31ms 0ms 4.4s
recipe (instructions) 5ms 7ms 7ms 37ms 0ms 3.5s
synthetic (title) 51ms 52ms 56ms 114ms 386ms 12.0s
synthetic (string inside object) 48ms 51ms 64ms 266ms 184ms 7.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Jan 14, 2025
Merged via the queue into next with commit 9266e11 Jan 14, 2025
58 checks passed
@bjoerge bjoerge deleted the chore/cli/bump-template-validator branch January 14, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants