Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Global Document References support #8299

Draft
wants to merge 11 commits into
base: next
Choose a base branch
from
Draft

Conversation

sgulseth
Copy link
Member

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:12pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:12pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:12pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 3:12pm
test-next-studio ⬜️ Ignored (Inspect) Jan 30, 2025 3:12pm

@juice49 juice49 force-pushed the next branch 2 times, most recently from 9caf5d8 to 691aad1 Compare January 23, 2025 13:56
@skogsmaskin skogsmaskin force-pushed the feat/dam-190/gdr branch 2 times, most recently from 9d4c639 to 2fbe79b Compare January 30, 2025 14:05
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Component Testing Report Updated Jan 30, 2025 3:16 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 21s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 30, 2025

⚡️ Editor Performance Report

Updated Thu, 30 Jan 2025 15:18:00 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 25.0 efps (40ms) -1ms (-2.4%)
article (body) 77.8 efps (13ms) 67.6 efps (15ms) +2ms (-/-%)
article (string inside object) 27.8 efps (36ms) 26.3 efps (38ms) +2ms (+5.6%)
article (string inside array) 23.0 efps (44ms) 23.8 efps (42ms) -2ms (-3.4%)
recipe (name) 52.6 efps (19ms) 50.0 efps (20ms) +1ms (+5.3%)
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 19.2 efps (52ms) 19.6 efps (51ms) -1ms (-1.9%)
synthetic (string inside object) 19.2 efps (52ms) 19.6 efps (51ms) -1ms (-1.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 48ms 62ms 278ms 282ms 10.5s
article (body) 13ms 16ms 20ms 142ms 195ms 5.2s
article (string inside object) 36ms 39ms 44ms 174ms 172ms 6.5s
article (string inside array) 44ms 47ms 55ms 160ms 411ms 7.5s
recipe (name) 19ms 21ms 22ms 47ms 0ms 6.8s
recipe (description) 18ms 20ms 26ms 40ms 2ms 4.7s
recipe (instructions) 6ms 7ms 8ms 15ms 0ms 3.1s
synthetic (title) 52ms 54ms 61ms 284ms 684ms 12.3s
synthetic (string inside object) 52ms 57ms 88ms 451ms 1062ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 62ms 75ms 463ms 899ms 10.8s
article (body) 15ms 18ms 22ms 99ms 335ms 5.9s
article (string inside object) 38ms 41ms 43ms 221ms 366ms 7.1s
article (string inside array) 42ms 45ms 51ms 155ms 285ms 7.1s
recipe (name) 20ms 22ms 26ms 43ms 0ms 6.8s
recipe (description) 18ms 19ms 24ms 37ms 0ms 4.4s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 51ms 53ms 57ms 134ms 714ms 16.9s
synthetic (string inside object) 51ms 54ms 66ms 249ms 1030ms 9.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants