-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): include _originalId
in groq2024
search, update refs adapter
#8395
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Component Testing Report Updated Jan 24, 2025 9:15 AM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Fri, 24 Jan 2025 09:20:33 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks good to me, though since @juice49 is the one that touched on this lately might be worth him giving a once-over :)
Description
Fixes a bug that occurs when using
groq2024
search and trying to create a reference to a document that is only a draft, no published version of this document exists.The problem is that when using
groq2024
the results include the document published id, even if it's a published or a draft, I think this is because it is using a perspective to query the data.To fix this we include the
_originalId
which represents the real id of the document, which is thedrafts
orversion
(coming soon)Refs.error.mov
What to review
Is this change correct?
Testing
groq 2024 tests have been updated.
Notes for release
fixes a regression in which references to non published documents fails when using
groq2024
search strategy