Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): make Content Releases opt-in #8470

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Jan 31, 2025

Description

This branch makes Content Releases opt-in, and enables it in Test Studio.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:56pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:56pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:56pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 4:56pm
test-next-studio ⬜️ Ignored (Inspect) Jan 31, 2025 4:56pm

Copy link
Contributor

No changes to documentation

@juice49 juice49 marked this pull request as ready for review January 31, 2025 16:47
@juice49 juice49 requested a review from a team as a code owner January 31, 2025 16:47
@juice49 juice49 requested review from RitaDias and removed request for a team January 31, 2025 16:47
The plugin is only executed if it is enabled. Therefore, it is
unnecessary to check whether it's enabled in the `ReleasesStudioLayout`
component, which is part of the plugin.
@juice49 juice49 requested a review from bjoerge January 31, 2025 16:49
@juice49 juice49 changed the title Feat/corel/opt in feat(sanity): make Content Releases opt-in Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Component Testing Report Updated Jan 31, 2025 4:57 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 29s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 1s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juice49!

@juice49 juice49 merged commit 5b24cc7 into feat/content-releases Jan 31, 2025
43 of 49 checks passed
@juice49 juice49 deleted the feat/corel/opt-in branch January 31, 2025 16:56
Copy link
Contributor

github-actions bot commented Jan 31, 2025

⚡️ Editor Performance Report

Updated Fri, 31 Jan 2025 17:01:24 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.3 efps (40ms) 22.2 efps (45ms) +6ms (+13.9%)
article (body) 59.7 efps (17ms) 59.5 efps (17ms) +0ms (+0.3%)
article (string inside object) 26.3 efps (38ms) 24.4 efps (41ms) +3ms (+7.9%)
article (string inside array) 23.3 efps (43ms) 21.7 efps (46ms) +3ms (+7.0%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 55.6 efps (18ms) 52.6 efps (19ms) +1ms (+5.6%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 18.2 efps (55ms) 20.0 efps (50ms) -5ms (-9.1%)
synthetic (string inside object) 18.9 efps (53ms) 20.4 efps (49ms) -4ms (-7.5%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 43ms 80ms 521ms 1015ms 11.0s
article (body) 17ms 20ms 51ms 246ms 504ms 6.4s
article (string inside object) 38ms 41ms 50ms 306ms 398ms 7.3s
article (string inside array) 43ms 45ms 48ms 172ms 184ms 7.0s
recipe (name) 20ms 21ms 24ms 47ms 0ms 6.8s
recipe (description) 18ms 21ms 24ms 37ms 0ms 4.7s
recipe (instructions) 6ms 6ms 8ms 9ms 0ms 3.1s
synthetic (title) 55ms 59ms 65ms 261ms 1069ms 12.9s
synthetic (string inside object) 53ms 55ms 76ms 401ms 870ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 58ms 97ms 501ms 1168ms 11.5s
article (body) 17ms 19ms 51ms 191ms 461ms 6.2s
article (string inside object) 41ms 42ms 48ms 262ms 297ms 7.1s
article (string inside array) 46ms 48ms 51ms 166ms 353ms 7.5s
recipe (name) 20ms 22ms 31ms 43ms 2ms 7.0s
recipe (description) 19ms 21ms 26ms 61ms 0ms 4.9s
recipe (instructions) 6ms 7ms 8ms 11ms 0ms 3.1s
synthetic (title) 50ms 54ms 90ms 128ms 805ms 12.6s
synthetic (string inside object) 49ms 55ms 67ms 645ms 1328ms 8.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants