Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with payloads #18

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Working with payloads #18

merged 1 commit into from
Jul 12, 2024

Conversation

nicolasparrague
Copy link
Collaborator

No description provided.

@nicolasparrague nicolasparrague self-assigned this Jun 19, 2024
@nicolasparrague nicolasparrague linked an issue Jun 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Flag Coverage Δ
LWC 71.37% <87.50%> (+14.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ult/lwc/workingWithPayloads/workingWithPayloads.js 100.00% <100.00%> (ø)
src-lookup/main/default/lwc/lookup/lookup.js 32.55% <0.00%> (+32.55%) ⬆️

... and 1 file with indirect coverage changes

@santiagoparradev santiagoparradev marked this pull request as draft June 20, 2024 16:57
@nicolasparrague nicolasparrague removed the request for review from santiagoparradev June 20, 2024 17:09
@nicolasparrague nicolasparrague marked this pull request as ready for review June 21, 2024 15:14
@nicolasparrague nicolasparrague requested review from santiagoparradev and removed request for santiagoparradev June 21, 2024 15:25
@santiagoparradev
Copy link
Owner

@nicolasparrague you are failing a job

src-lookup-sample/main/default/classes/AccountLookup.cls Outdated Show resolved Hide resolved
src-lookup-sample/main/default/classes/AccountLookup.cls Outdated Show resolved Hide resolved
}

get accountValueEmpty() {
return !this.accountValue;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this
Just use a lwc:if this.account on your html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the requirement says that the contact must be deactivated when you do not select the account

@santiagoparradev santiagoparradev merged commit 4288784 into main Jul 12, 2024
3 checks passed
@santiagoparradev santiagoparradev deleted the WorkingPayloads branch July 12, 2024 16:49
@nicolasparrague nicolasparrague restored the WorkingPayloads branch July 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with payloads (new tab sample)
2 participants