Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila] add metrics for limes capacity plugin #7690

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Carthaca
Copy link
Contributor

we move the function definition away from limes and take
ownership in manila

@Carthaca Carthaca force-pushed the snapmirror_query_for_limes branch 2 times, most recently from d8f45d7 to daa17ed Compare January 22, 2025 09:39
@Carthaca Carthaca marked this pull request as ready for review January 22, 2025 09:40
Copy link
Member

@chuan137 chuan137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we move the function definition away from limes and take
ownership in manila

additionally we allow 'hxm_backups' snapshot policy and
use the new harvester metrics
@Carthaca Carthaca force-pushed the snapmirror_query_for_limes branch from daa17ed to 723193e Compare January 22, 2025 10:40
@Carthaca Carthaca merged commit 10e125a into master Jan 22, 2025
2 of 4 checks passed
@Carthaca Carthaca deleted the snapmirror_query_for_limes branch January 22, 2025 11:41
Carthaca added a commit to sapcc/limes that referenced this pull request Jan 29, 2025
Move the definition of the query out to manila service to have the
logic in faster control of the team that operates manila.

query was added in sapcc/helm-charts#7690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants