Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ada: add option --igtf. Fixes #10. #55

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Ada: add option --igtf. Fixes #10. #55

merged 1 commit into from
Feb 10, 2025

Conversation

onnozweers
Copy link
Contributor

The option --igtf requires 'true' or 'false' as a value. If the option is not specified, 'true' is assumed. Most dCache APIs have IGTF compatible host certificates (also called: Grid certificates), which require the curl option --capath, to point curl to the Grid root CA certificates. But when a dCache API does not have a Grid certificated, but instead a "normal" certificate like a "Let's Encrypt" cert, the curl option --capath should not be used. So, in such a case, you can use --igtf false, or in the ada.conf igtf=false, to prevent the curl option --capath. Curl then uses its own set of root CA certificates.
If Ada just works for you, you don't need this option. If Ada has trouble connecting to an API, try this option.

Also, don't print the entire manual when an invalid option has been specified. Show only the error, with instruction how to view the help text.

@onnozweers onnozweers requested a review from hailihu February 7, 2025 15:01
Copy link
Contributor

@hailihu hailihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Cannot fully test the functionality but the current unit/integration tests pass, so that seems sufficient.

@hailihu hailihu merged commit 17c7c95 into master Feb 10, 2025
1 check passed
@onnozweers onnozweers deleted the fix-non-igtf-certs branch February 11, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unconditional use of curl option --capath is wrong in case server provides a non-IGTF certificate
2 participants