proof of concept: reimplement gestures to enable compose ui blending on web #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sargunv
changed the title
sargunv
changed the title
sargunv
force-pushed
the
poc_pass_through_panning_input
branch
from
990e8e6 to
6c4e157
Compare
sargunv
changed the title
sargunv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could solve #210 if we reimplement all the gestures to make up for the blocked pointer input. This branch is a proof of concept, with basic pan, zoom, and rotate implemented in Compose. This PoC lacks support for fling velocity, pitch, centroids (rotate/zoom "around" a point), keyboard or right click controls, double tap and quick zoom, multitouch on web, and the desktop webview.
This does disable the SDK's standard controls. So it can only be merged if we decide to forgo those controls entirely (something we probably will do for native anyway, see #218)