Document and simplify clusterproperties interface #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+18
to
+23
| * | ||
| * - `cluster`: Is `true` if the point is a cluster | ||
| * - `cluster_id`: A unique id for the cluster to be used in conjunction with the cluster | ||
| * inspection methods. | ||
| * - `point_count`: Number of original points grouped into this cluster | ||
| * - `point_count_abbreviated`: An abbreviated point count |
There was a problem hiding this comment.
[spotless] reported by reviewdog 🐶
Suggested change
| * | |
| * - `cluster`: Is `true` if the point is a cluster | |
| * - `cluster_id`: A unique id for the cluster to be used in conjunction with the cluster | |
| * inspection methods. | |
| * - `point_count`: Number of original points grouped into this cluster | |
| * - `point_count_abbreviated`: An abbreviated point count | |
| * - `cluster`: Is `true` if the point is a cluster | |
| * - `cluster_id`: A unique id for the cluster to be used in conjunction with the cluster | |
| * inspection methods. | |
| * - `point_count`: Number of original points grouped into this cluster | |
| * - `point_count_abbreviated`: An abbreviated point count |
There was a problem hiding this comment.
This change would break formatting this as a list in Android Studio.
Bad dog!
Comment on lines
+31
to
+32
| * - the top of the viewport if [illuminationAnchor] = [IlluminationAnchor.Viewport] or | ||
| * - north if [illuminationAnchor] = [IlluminationAnchor.Map] |
There was a problem hiding this comment.
[spotless] reported by reviewdog 🐶
Suggested change
| * - the top of the viewport if [illuminationAnchor] = [IlluminationAnchor.Viewport] or | |
| * - north if [illuminationAnchor] = [IlluminationAnchor.Map] | |
| * - the top of the viewport if [illuminationAnchor] = [IlluminationAnchor.Viewport] or | |
| * - north if [illuminationAnchor] = [IlluminationAnchor.Map] |
There was a problem hiding this comment.
This change would break formatting this as a list in Android Studio.
Bad dog!
…ecompose/core/source/GeoJsonOptions.kt Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #236
Apart from adding documentation, the only thing I changed in this draft PR was so that in the
ClusterPointsDemoI could writeinstead of
(I don't mind to revert this before the (documentation) PR is merged, I was just experimenting around.)
Anyway, for some reason, this doesn't lead to a crash anymore. Can you make something of that?
Also, I can't test this on iOS, but according to the source code what seems to be expected is a dictionary with strings as keys and arrays with two expressions as values. The current/previous code seems to be just one expression.