[OntoloGui] fix ros undefined symbol

sarthou · Dec 6, 2023 · ac029ad · ac029ad
1 parent 9ccac5d
commit ac029ad
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -32,8 +32,8 @@ function(add_onto_library TARGET)
     endif()
     add_library(${TARGET} ${ARGN})
     add_dependencies(${TARGET} ontologenius_gencpp ${catkin_EXPORTED_TARGETS})
-    target_include_directories(${TARGET} PUBLIC include PRIVATE ${catkin_INCLUDE_DIRS})
-    target_link_libraries(${TARGET} PRIVATE ${catkin_LIBRARIES})
+    target_include_directories(${TARGET} PUBLIC include ${catkin_INCLUDE_DIRS})
+    target_link_libraries(${TARGET} PUBLIC ${catkin_LIBRARIES}) # PRIVATE has been removed fot ontoloGUI
     set_target_properties(${TARGET} PROPERTIES CXX_STANDARD 17 CXX_STANDARD_REQUIRED ON)
     target_compile_options(${TARGET} PRIVATE -Wall -Wextra)
     target_enable_sanitizers(${TARGET})
@@ -405,13 +405,7 @@ set( QT_SOURCES
 ##############################################################################
 
 add_executable(ontoloGUI ${QT_SOURCES} ${QT_RESOURCES_CPP} ${QT_FORMS_HPP} ${QT_MOC_HPP})
-target_include_directories(ontoloGUI
-  PRIVATE
-    ${catkin_INCLUDE_DIRS}
-)
-add_dependencies(ontoloGUI ontologenius_gencpp ${catkin_EXPORTED_TARGETS})
 target_link_libraries(ontoloGUI
-    ${catkin_LIBRARIES}
     Qt5::Core
     Qt5::Widgets
     Qt5::PrintSupport

diff --git a/include/ontologenius/graphical/ontoloGUI/ontologui.h b/include/ontologenius/graphical/ontoloGUI/ontologui.h
@@ -6,12 +6,9 @@
 #include <QTextCursor>
 
 #include "ontologenius/OntologiesManipulator.h"
-#include <ros/ros.h>
 #include <vector>
 #include <string>
 
-#include "std_msgs/String.h"
-
 namespace Ui {
 class ontoloGUI;
 }

diff --git a/src/graphical/ontoloGUI/ontologui.cpp b/src/graphical/ontoloGUI/ontologui.cpp
@@ -5,13 +5,8 @@
 
 #include <QScrollBar>
 
-#include "ontologenius/OntologeniusService.h"
-#include "std_msgs/String.h"
-
 #include <regex>
 
-#define QUEU_SIZE 1000
-
 ontoloGUI::ontoloGUI(QWidget *parent) :
     QMainWindow(parent),
     ui(new Ui::ontoloGUI)