-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #74 #75
Fix #74 #75
Conversation
Fixes sarugaku#55 Tries to also address sarugaku#21, sarugaku#35
@uranusjr After digging into this again I went the extra mile and also did the refactoring you mentioned here: #55 (comment). This means it fixes #55 and should also fix #35. Additionally, since I wanted to make the |
Let’s not be greedy, and only fix one issue at a time instead. |
I pushed a commit to refactor the |
Looks good to me. Still correctly detects shell inside docker container on running on M1 MacBook Pro/osx-arm64 both with rosetta and qemu amd64 emulation. |
Fixes #74