Fix for "too many open files" error on OSX. #3183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
added a commit
to bep/golibsass
that referenced
this pull request
Aug 28, 2024
Patch borrowed from sass/libsass#3183 by @tom-un See See gohugoio/hugo#12649
bep
added a commit
to bep/golibsass
that referenced
this pull request
Aug 28, 2024
Patch borrowed from sass/libsass#3183 by @tom-un See See gohugoio/hugo#12649
bep
added a commit
to bep/golibsass
that referenced
this pull request
Aug 28, 2024
Patch borrowed from sass/libsass#3183 by @tom-un See See gohugoio/hugo#12649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
go-libsass(which useslibsass) on OSX 14.1.1, it would fail with "File to import not found or unreadable: " errors.The issue is in
libsassin theread_filefunction infile.cpp. On non-_WIN32 OS's it usesstd::ifstreamto read the file. On OSX it always fails withstrerror(errno)saying "Failure: too many open files".On my system,
ulimitandulimit -nreturn the default "unlimited" / 256. So I tried raising it in/Library/LaunchDaemons/limit.maxfiles.plistbut it still didn't help.I tried reverting the most recent change in
file.cppwhich usedfopeninstead ofstd::ifstream. It still failed.So, I tried using the Darwin
open/readand it works!