Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1117) dark site deployment #542

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from
Open

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Apr 9, 2024

Refer to internal ticket comment on May 8 for dev branch information being used for Experimental dark site support code review.

@dhoucgitter dhoucgitter self-assigned this Apr 9, 2024
@dhoucgitter dhoucgitter marked this pull request as draft April 9, 2024 23:48
@dhoucgitter
Copy link
Member Author

dhoucgitter commented Apr 10, 2024

Note for reviewers, https://github.com links to files are duplicated, the first link points to the current dev branch, the second branch link should be the same except it should point to the main branch as a target. I'll remove the dev branch label and link after the code review but before pushing to staging.

@dhoucgitter dhoucgitter changed the base branch from main to staging May 1, 2024 15:37
@dhoucgitter dhoucgitter marked this pull request as ready for review May 8, 2024 19:28
@dhoucgitter dhoucgitter added the enhancement New feature or request label May 8, 2024
@dhoucgitter dhoucgitter requested review from jarpat, thpang, riragh and sayeun May 8, 2024 20:26
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of script and eof issues also some general comments.

K8S_minor_version=25 # K8s v1.22.X minor would be 22 ... K8s v1.21.X minor version would be 21. This must match your deployment!
DEPLOYMENT_VERSION=main # main will pull latest release of viya4-deployment. But this can be set to a specific version if needed, example: 5.2.0

DOCKER_SUDO= # put sudo here, if you require sudo docker commands... else leave blank
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

. metrics_server.sh
. nfs_subdir_external_provisioner.sh
. openldap.sh
. ebs_driver.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

aws ecr get-login-password --region $AWS_REGION | $DOCKER_SUDO docker login --username AWS --password-stdin $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com

# # ## puch local image to ecr
$DOCKER_SUDO docker push $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/cluster-autoscaler:$TAG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

aws ecr get-login-password --region $AWS_REGION | $DOCKER_SUDO docker login --username AWS --password-stdin $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com

# # ## puch local image to ecr
$DOCKER_SUDO docker push $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/metrics-server:$TAG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

## pull the image
$DOCKER_SUDO docker pull $REPOSITORY:$TAG


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra lines

aws ecr get-login-password --region $AWS_REGION | $DOCKER_SUDO docker login --username AWS --password-stdin $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com

# # ## puch local image to ecr
$DOCKER_SUDO docker push $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/nfs-subdir-external-provisioner:$TAG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

aws ecr get-login-password --region $AWS_REGION | docker login --username AWS --password-stdin $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com

# # ## puch local image to ecr
$DOCKER_SUDO docker push $AWS_ACCT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$IMAGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line ending issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the scripts in this section many of them have extra lines in the file and no eof marker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing Thomas, expect a new commit with those updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thpang, I fixed end-of-line issues and removed duplicate blank lines from the identified files, please take another look to see if those are looking good now, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thpang, please let me know if there are additional concerns I need to address, thanks. Hoping to merge this to staging ASAP.

@dhoucgitter dhoucgitter requested a review from thpang May 9, 2024 17:41
@dhoucgitter dhoucgitter requested a review from jarpat May 15, 2024 03:30
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants