chore: (IAC-1330) Update container structure workflow to run acceptance test for PRs targeting staging branch #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce test on pushes to staging branch
dhoucgitter
changed the title
jarpat
approved these changes
Feb 15, 2024
riragh
approved these changes
Feb 15, 2024
sayeun
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the container structure test github action only runs on pushes and pull requests to the main branch. That is too late and can result in acceptance test failures when creating the staging->main PR when it's time to create a new release. It would be more helpful for that acceptance test to run earlier. Adding a trigger to run this same test for pull requests to staging branch also which will allow us to find any failures earlier in our workflow.
Test
Screen capture of the checks run below indicate that the container acceptance tests ran for this PR when it was created and targeted to merge into staging which was the goal of this change.