Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (#PSKD-410) - Enable NIST support flag #294

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

dhoucgitter
Copy link
Member

Summary

viya4-iac-aws main branch will be updated with the new enable_nist_features configuration/feature flag variable for future work

Tests

Scenario enable_nist_flag Cadence Notes
1 false n/a v1.28 EKS cluster successfully created and destroyed
2 true n/a v1.28 EKS cluster successfully created and destroyed

@dhoucgitter dhoucgitter self-assigned this Jul 11, 2024
@dhoucgitter dhoucgitter added the enhancement New feature or request label Jul 11, 2024
@dhoucgitter dhoucgitter requested review from jarpat and saschjmil July 11, 2024 15:44
jarpat
jarpat previously approved these changes Jul 11, 2024
saschjmil
saschjmil previously approved these changes Jul 11, 2024
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhoucgitter dhoucgitter dismissed stale reviews from saschjmil and jarpat via 1829306 July 11, 2024 19:26
@dhoucgitter dhoucgitter requested review from jarpat and saschjmil July 11, 2024 21:08
@dhoucgitter dhoucgitter merged commit d19b119 into main Jul 12, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the feat/nist-feature-flag branch July 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants