Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (PSKD-494) AWS - private endpoint type for S3 should be of type Interface #295

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Jul 22, 2024

Summary:

Revise a previously made update to the type for the s3 private endpoint used in private EKS clusters.
Issue Description: Be default, the viya4-iac-aws project should create the s3 private endpoint with a type of "interface". Currently, viya4-iac-aws creates a s3 private endpoint with a type of "gateway" for use with private EKS clusters. IAC-729 incorrectly advised that the s3 private endpoint should be changed to a type of "gateway". That could work, but additional more complex routing configuration not already present in the project would be required in order for the s3 private endpoint to work with a type "gateway".

Additional testing since then has shown that the existing "interface" type for the s3 private endpoint is sufficient and works as intended, so this work item will revert the ill-advised change originally requested by IAC-729.

Tests

Use IAC AWS (Run a terraform apply command, BYON = 0) to successfully create an EKS K8S cluster with the configuration variable cluster_api_mode set to the following values:

  • public
  • private

@dhoucgitter dhoucgitter added the bug Something isn't working label Jul 22, 2024
@dhoucgitter dhoucgitter self-assigned this Jul 22, 2024
@dhoucgitter dhoucgitter requested review from saschjmil and jarpat July 22, 2024 17:09
@dhoucgitter dhoucgitter merged commit 3191d95 into staging Jul 22, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the fix/iac-1492 branch July 22, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants