Skip to content

Commit

Permalink
feat: (PSKD-709) Default version updated
Browse files Browse the repository at this point in the history
  • Loading branch information
riragh committed Nov 6, 2024
1 parent cc1aadf commit da9cbc7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/CONFIG-VARS.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ stateful = {
When `storage_type=ha` and `storage_type_backend=netapp` are specified, [Google NetApp Volumes](https://cloud.google.com/netapp/volumes/docs/discover/overview) service is created. Before using this storage option,
- Enable the Google Cloud NetApp Volumes API for your project, see how to enable [here](https://cloud.google.com/netapp/volumes/docs/get-started/configure-access/initiate-console-settings#enable_the_api).
- Grant access to NetApp Volumes operations by granting IAM roles to users. The two predefined roles are `roles/netapp.admin` and `roles/netapp.viewer`. You can assign these roles to specific users or service accounts.
- NetApp Volumes is available in several regions. For details about region availability, see [NetApp Volumes locations](https://cloud.google.com/netapp/volumes/docs/locations).

| Name | Description | Type | Default | Notes |
| :--- | ---: | ---: | ---: | ---: |
Expand Down
3 changes: 2 additions & 1 deletion modules/google_netapp/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ resource "google_netapp_volume" "netapp-nfs-volume" {
access_type = "READ_WRITE"
allowed_clients = var.allowed_clients
has_root_access = true
nfsv4 = true
nfsv3 = contains(var.protocols, "NFSV3") ? true : false
nfsv4 = contains(var.protocols, "NFSV4") ? true : false
}
}

Expand Down
2 changes: 1 addition & 1 deletion modules/google_netapp/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ variable "service_level" {
variable "protocols" {
description = "The target volume protocol expressed as a list. Allowed combinations are ['NFSV3'], ['NFSV4'], ['SMB'], ['NFSV3', 'NFSV4'], ['SMB', 'NFSV3'] and ['SMB', 'NFSV4']. Each value may be one of: NFSV3, NFSV4, SMB."
type = list(string)
default = ["NFSV4"]
default = ["NFSV3"]
}

variable "capacity_gib" {
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ variable "netapp_service_level" {
variable "netapp_protocols" {
description = "The target volume protocol expressed as a list. Each value may be one of: NFSV3, NFSV4, SMB. Currently, only NFS is supported."
type = list(string)
default = ["NFSV4"]
default = ["NFSV3"]

validation {
condition = var.netapp_protocols != null ? startswith(var.netapp_protocols[0], "NFS") : null
Expand Down

0 comments on commit da9cbc7

Please sign in to comment.