Fix to support removal of --short option from kubectl version #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubectl version --short is no longer supported at 1.28. Switching to using --output=json and parsing this.
|
@greg-wootton Thank you for this PR. Unfortunately, the project team is a little underhanded at the moment due to illness and other unavoidable absences. However, we hope to operational again by next week. At that point, we will review this PR and sort out a plan for incorporating it into project. We'll keep you updated. Regards, |
|
We decided to handle this issue with slightly different syntax (pushed as #652). Abandoning this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl version --short is no longer supported at 1.28. Switching to using --output=json and parsing this with tr and sed.