fix: reset work dir parser each time #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Wu <[email protected]>
scnwwu
force-pushed
the
p-workdirparser
branch
from
bb0c16c to
9f60480
Compare
smorrisj
approved these changes
Nov 8, 2024
tianliang657
added
testing
tianliang657
approved these changes
Nov 11, 2024
tianliang657
added
verified
ready for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1266
The error happened after the parser had started capturing log lines. In the second time the parser is still in the stale state. We should reset the parser each time before getting the work dir.
Testing
Test case in #1266