-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert upstream proxy does the traffic #327
Conversation
PR Summary
|
e2e/setups.go
Outdated
@@ -131,7 +137,7 @@ func PacSetups() []setup.Setup { | |||
AddService( | |||
forwarder.HttpbinService()). | |||
MustBuild(), | |||
Run: "^TestProxy", | |||
Run: "^TestProxy|^TestUpstreamCheck$", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this test TestProxyUpstream and given the env variables it would ensure that upstream proxy is either used or not.
The name is used in the Via header in request. From now on users can specify custom names to represent their proxies.
Users can benefit from explicit access to response body.
The test checks if the traffic goes through the upstream-proxy. It works only when the httpbin protocol is http.
31f997c
to
0b67925
Compare
The assert only works for http endpoints.