proxyproto: PROXY protocol net.Conn and net.Listener impl #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
force-pushed
the
mmt/proxyproto_v3
branch
from
743d1c3
to
57019b8
Compare
Use github.com/pires/go-proxyproto header parsing and provide better (safer) net.Conn and net.Listener implementations. The Conn type is designed after tls.Conn. We never read more than header bytes from connection. This allows to eliminate any 3rd party readers, and to use the connection ReadFrom() and WriteTo() functions if provided. The underlying connection is available via Conn.NetConn(). On context cancellation the connection is closed to terminate the paring go routine, and to avoid unspecified behaviour caused by double reads from header parsing and user code.
mmatczuk
force-pushed
the
mmt/proxyproto_v3
branch
from
57019b8
to
54d89e8
Compare
Choraden
reviewed
Sep 23, 2024
| panic("proxy protocol header read: unexpected data after header") | ||
| } | ||
|
|
||
| resCh <- r |
There was a problem hiding this comment.
Let's make buffered chanel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use github.com/pires/go-proxyproto header parsing and provide better (safer) net.Conn and net.Listener implementations.