Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add main class for diktat.jar #1557

Closed
3 tasks done
nulls opened this issue Nov 10, 2022 · 2 comments · Fixed by #1566 or #1653
Closed
3 tasks done

Add main class for diktat.jar #1557

nulls opened this issue Nov 10, 2022 · 2 comments · Fixed by #1566 or #1653
Assignees
@nulls
Milestone
2.0.0

Comments

@nulls
Copy link
Member

nulls commented Nov 10, 2022 •
edited
Loading

Produce additional artifact with required ktlint version.
It can be zip\tar.gz\tgz archive with final diktat fat jar and ktlint with proper version

Add main class for diktat which runs KtLint.format or KtLint.lint.
Need to support the same arguments as Benedikt

  • Add the main class (Add main for diktat.jar #1566 hasn't been cherry-picked into master).
  • Main-Class attribute in META-INF/MANIFEST.MF of the fat jar
  • Class-Path attribute in META-INF/MANIFEST.MF of the fat jar
@nulls
Copy link
Member Author

nulls commented Nov 10, 2022 •
edited
Loading

It's required for saveourtool/benedikt#6 can be resolved by reading pom.xml for resoling required version of ktlint

@0x6675636b796f75676974687562
Copy link
Member

Available since the 1.2.4.2 release of Benedikt.

What's missing, though, is KtLint version resolution (currently, both Diktat and KtLint versions are hard-coded in the script)

@nulls nulls mentioned this issue Nov 15, 2022
Closed
8 tasks
@nulls nulls changed the title Produce additional artifact with required ktlint version Add main class for diktat.jar Nov 15, 2022
nulls added a commit that referenced this issue Nov 15, 2022
@nulls
Add main for diktat.jar
7fee58a 
### What's done:
* renamed diktat-ruleset to diktat
* added DiktatMain
* updated gradle plugin to use only diktat as dependency

It closes #1557
@nulls nulls mentioned this issue Nov 15, 2022
Merged
Open
@nulls nulls added this to the 2.0.0 milestone Apr 3, 2023
@nulls nulls mentioned this issue Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Add main for diktat.jar saveourtool/diktat
Diktat CLI runner saveourtool/diktat
2 participants
@nulls @0x6675636b796f75676974687562