-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New languages: Welsh (Celtic) and Chechen (Nakho-Dagestanian) #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests do pass in 333->343, 341->343, 572->exit but coverage marks as not testes
Hi, is there any action needed from me ? checks seemed to have passed successfully :-) |
Hi, sorry for the delay, seems to be some conflicts with the main branch, can you fix it, pls? Thanks |
I resolved the conflict. Should be OK now |
mrodriguezg1991
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # by Johannes Heinecke
Changes proposed in this pull request:
support of two new languages
Status
How to verify this change
run tests for Welsh and Chechen
Additional notes
Welsh
I needed Welsh for a personal project. I also added Chechen since was on it.
The Welsh function has two additional arguments:
gender
(valid valuesfem
ormasc
) and the counted object. The latter is needed since in Welsh the counted object does not follow the number (like English seventeen dogs) but is inserted within the numeric expression:e.g.
num2words(17, lang="cy", counted="ci", gender="masc")
Currencies are used in the same way
E.g.
num2words(31.50, lang='cy', to="currency", currency="GBP")
After a numeral the noun is always in Singular
Chechen
The Chechen API as also two language specific arguments,
case
(valid values:abs
,gen
,dat
,erg
,instr
,mat
,comp
,all
,obl
,attr
) and the semantic class (gender). The casesobl
is needed when the numeral is used with a noun in non-Absolute Case,attr
is needed (only internally) if the numeral precedes another numeral (ши бӀе == 2 * 100). All other cases are used if the numeral is used as a noun (Tree are coming
)Chechen has 6 classes (genders) which are marked by 4 letters ("д", "б", "й" or "в".
Adjectives, numerals and verbs agree with the noun in class. In case of numerals it is only 4, 14, 40, 80 which show the class letter. If not given "д" is used:
e.g.
num2words(4, lang='ce', case="abs", clazz="в")