re-publish and re-discover immediately when the node disconnects #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connectivity changes.
…sconnects, instead of on the connectivityChanged signal.
aberaud
requested changes
Jun 25, 2024
src/dhtrunner.cpp
Outdated
| @@ -690,8 +696,13 @@ DhtRunner::loop_() | |||
| if (nstatus4 != status4 || nstatus6 != status6) { | |||
| status4 = nstatus4; | |||
| status6 = nstatus6; | |||
| if (statusCb) | |||
| statusCb(status4, status6); | |||
| if (!statusCbs.empty()) | |||
src/dhtrunner.cpp
Outdated
| if (!statusCbs.empty()) | ||
| { | ||
| for (auto& cb : statusCbs){ | ||
| if (cb) |
src/dhtrunner.cpp
Outdated
| statusCb = std::move(context.statusChangedCallback); | ||
| } | ||
| statusCbs.clear(); | ||
| statusCbs.emplace_back(std::move(context.statusChangedCallback)); |
There was a problem hiding this comment.
only emplace if statusChangedCallback is not {}.
include/opendht/dhtrunner.h
Outdated
| @@ -519,7 +519,8 @@ class OPENDHT_PUBLIC DhtRunner { | |||
|
|
|||
| NodeStatus status4 {NodeStatus::Disconnected}, | |||
| status6 {NodeStatus::Disconnected}; | |||
| StatusCallback statusCb {nullptr}; | |||
|
|
|||
| std::list<StatusCallback> statusCbs {}; | |||
include/opendht/dhtrunner.h
Outdated
| @@ -409,7 +409,7 @@ class OPENDHT_PUBLIC DhtRunner { | |||
| void run(const Config& config, Context&& context); | |||
|
|
|||
| void setOnStatusChanged(StatusCallback&& cb) { | |||
| statusCb = std::move(cb); | |||
| statusCbs.emplace_back(std::move(cb)); | |||
src/dhtrunner.cpp
Outdated
| @@ -264,6 +263,13 @@ DhtRunner::run(const Config& config, Context&& context) | |||
| } | |||
| } | |||
| } | |||
| if (config.peer_discovery && config.peer_publish) { | |||
There was a problem hiding this comment.
what if only peer_discovery or peer_publish is true ?
There was a problem hiding this comment.
It should be config.peer_discovery or config.peer_publish so i changed it to if (peerDiscovery_).
aberaud
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.