adjust input parsing #122
Merged
adjust input parsing #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcai
commented
Oct 27, 2024
| @@ -291,6 +290,22 @@ def input_output_for(operation, input_output) | |||
| end | |||
| end | |||
|
|
|||
| # If the message is not found, we should use the operation name as the message name for document style operations | |||
| # applies only to output | |||
There was a problem hiding this comment.
I arbitrarily decided to apply this logic on output only, because it seemed to fix the most issues while minimizing new ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some apparent regressions from #114
see savonrb/savon#1016 for reproduction
Unfortunately this change isn't motivated by any specific understanding of the relevant specification, only that it appears to address issues that have been reported since the change specified in #114 was released.
other changes
I tried my best to add a few lines of documentation as i reviewed the code to make it easier in the future to parse what is happening.
Slightly refactored a weird and kinda awkward usage of
super()in one of the tests