Add another overload to path function #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to pass NinjaAPI's ``.urls`` to Django's ``path`` function. Adding ``URLPattern`` to ``IncludedURLConf`` didn't work. My guess is that this is caused by the `str | None` in ``IncludedURLConf`` which is not as strict as the return type of ``ninja_api.urls`` fixes sbdchd#173
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pass NinjaAPI's
.urlsto Django'spathfunction.Adding
URLPatterntoIncludedURLConfdidn't work. My guess is that this is caused by thestr | NoneinIncludedURLConfwhich is not as strict as the return type ofninja_api.urlsfixes #173