contrib/admin/options: improve types #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the type hints for `BaseModelAdmin`, `ModelAdmin`, and `InlineModelAdmin` by: 1. Removing private method definitions 2. Use the `_ModelT` generic variable more 3. Make `Any` return types more specific It think the highest value change here is `ModelAdmin.get_form`, which is what prompted me to make these changes in the fist place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the type hints for
BaseModelAdmin,ModelAdmin, andInlineModelAdminby:_ModelTgeneric variable moreAnyreturn types more specificIt think the highest value change here is
ModelAdmin.get_form, which is what prompted me to make these changes in the fist place.