Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: add improved undojoin solution. #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bachhh
Copy link

@bachhh bachhh commented Sep 12, 2021

@hoschi proposed a nice fix for issue #134, I hope it can be put on the front page, in README.md.

@hoschi proposed a nice fix for issue sbdchd#134, I hope it can be put on the front page, in README.md.
@hoschi
Copy link

hoschi commented Sep 12, 2021

Is this still needed? I don't have it in my vimrc anymore. 🤔

@bachhh
Copy link
Author

bachhh commented Sep 17, 2021

I still get this issue on Neovim 5.0.
But this surprised me a bit, when an author doesn't use their own plugin anymore. Did you find something better ? 🤔

@hoschi
Copy link

hoschi commented Sep 17, 2021

I use Neoformat every day, I just don't have the fix from #134 anymore in my vimrc. The problem is four years old, with my comment I just wanted to question if it is still a problem. I'm not the author of Neoformat.

@bachhh
Copy link
Author

bachhh commented Sep 17, 2021

Very sorry that i misread your Github handle, my brain wasn't working well this afternoon, that was very embarrassing of me.
Yeah I still got that strange undo bug on Nvim 0.5.0, did you not also get this ?

@hoschi
Copy link

hoschi commented Sep 17, 2021

Ok I found whey I don't need the fix anymore. I created a shortcut to write files a long time ago, this one decides what happens on a "per project" basis and handles formatting as well. Therefore, I don't need to fix the original problem and don't have the fix in vimrc anymore.

I tested #134 again and it still occurs, so the PR is totally valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants