feat(plasma-icons): Add icons for `16 dp` #1162

neretin-trike · 2022-03-28T11:19:43Z

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/demo-canvas-app@0.70.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-b2c@1.55.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-icons@1.74.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-temple@1.52.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-ui@1.93.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-web@1.90.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/showcase@0.112.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-ui-docs@0.61.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-web-docs@0.48.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
npm install @sberdevices/plasma-website@0.45.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
# or 
yarn add @sberdevices/demo-canvas-app@0.70.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-b2c@1.55.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-icons@1.74.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-temple@1.52.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-ui@1.93.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-web@1.90.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/showcase@0.112.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-ui-docs@0.61.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-web-docs@0.48.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0
yarn add @sberdevices/plasma-website@0.45.0-canary.1162.9ea49994d9c6079cdd61774c32eecdad3267c78b.0

codecov · 2022-03-28T11:51:27Z

Codecov Report

Merging #1162 (802dcb3) into master (3b513ab) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   88.81%   88.92%   +0.11%     
==========================================
  Files         442      445       +3     
  Lines        6027     6087      +60     
  Branches     1732     1760      +28     
==========================================
+ Hits         5353     5413      +60     
  Misses        673      673              
  Partials        1        1

Flag	Coverage Δ
plasma-b2c	`95.84% <ø> (ø)`
plasma-core	`94.30% <100.00%> (+0.10%)`	⬆️
plasma-temple	`82.34% <ø> (ø)`
plasma-ui	`94.55% <100.00%> (+0.15%)`	⬆️
plasma-web	`92.32% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/plasma-ui/src/components/Badge/Badge.tsx	`100.00% <ø> (ø)`
packages/plasma-ui/src/components/Card/Card.tsx	`100.00% <ø> (ø)`
...asma-ui/src/components/ProductCard/ProductCard.tsx	`100.00% <100.00%> (ø)`
.../src/components/ProductCard/ProductCardStepper.tsx	`100.00% <100.00%> (ø)`
.../plasma-ui/src/components/Stepper/Stepper.hooks.ts	`100.00% <100.00%> (ø)`
...kages/plasma-ui/src/components/Stepper/Stepper.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3af742...802dcb3. Read the comment docs.

SberDevices-Eva · 2022-03-29T07:28:00Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1162/

SberDevices-Eva · 2022-03-29T07:46:18Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1162/
ui storybook: http://plasma.sberdevices.ru/pr-1162/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1162/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1162/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1162/temple-storybook/

SberDevices-Eva · 2022-03-30T06:35:58Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1162/

SberDevices-Eva · 2022-03-30T06:47:55Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1162/
ui storybook: http://plasma.sberdevices.ru/pr-1162/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1162/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1162/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1162/temple-storybook/

SberDevices-Eva · 2022-03-30T13:17:34Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1162/

SberDevices-Eva · 2022-03-30T13:33:25Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1162/
ui storybook: http://plasma.sberdevices.ru/pr-1162/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1162/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1162/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1162/temple-storybook/

SberDevices-Eva · 2022-04-04T09:24:50Z

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1162/

SberDevices-Eva · 2022-04-04T09:46:23Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1162/
ui storybook: http://plasma.sberdevices.ru/pr-1162/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1162/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1162/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1162/temple-storybook/

Yeti-or · 2022-04-11T07:59:22Z

packages/plasma-icons/src/scalable/Icon.assets.16/Add.tsx

+    <svg width="100%" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


clipRule можно убрать

Yeti-or · 2022-04-11T08:10:33Z

packages/plasma-icons/src/scalable/Icon.assets.16/Alpha.tsx

+    <svg width="100%" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


можно убрать и fillRule и clipRule

Yeti-or · 2022-04-11T08:12:00Z

packages/plasma-icons/src/scalable/Icon.assets.16/Calendar.tsx

+    <svg width="100%" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


и fillRule и clipRule

Yeti-or · 2022-04-11T08:14:17Z

packages/plasma-icons/src/scalable/Icon.assets.16/Call.tsx

+
+export const Call: React.FC<IconProps> = (props) => (
+    <svg width="100%" viewBox="0 0 23 23" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <g filter="url(#filter0D116133)">


я что-то не понимаю что этот фильтр делает;
если его убрать то в демо ничего не меняется

Yeti-or · 2022-04-11T08:16:57Z

packages/plasma-icons/src/scalable/Icon.assets.16/Call.tsx

+        <g filter="url(#filter0D116133)">
+            <path
+                fillRule="evenodd"
+                clipRule="evenodd"


можно убрать и fillRule и clipRule

Yeti-or · 2022-04-11T10:16:24Z

packages/plasma-icons/src/scalable/Icon.assets.16/VideoOff.tsx

+    <svg width="100%" viewBox="0 0 17 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


Yeti-or · 2022-04-11T10:18:20Z

packages/plasma-icons/src/scalable/Icon.assets.16/Volume1.tsx

+
+export const Volume1: React.FC<IconProps> = (props) => (
+    <svg width="100%" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <g clipPath="url(#clip0116114)">


нужен ли нам этот фильтр ??

Yeti-or · 2022-04-11T10:18:24Z

packages/plasma-icons/src/scalable/Icon.assets.16/Volume1.tsx

+        <g clipPath="url(#clip0116114)">
+            <path
+                fillRule="evenodd"
+                clipRule="evenodd"


Yeti-or · 2022-04-11T10:18:39Z

packages/plasma-icons/src/scalable/Icon.assets.16/Volume1.tsx

+
+import { IconProps } from '../IconRoot';
+
+export const Volume1: React.FC<IconProps> = (props) => (


странное название в этом паке, нет других volume ?

Yeti-or · 2022-04-11T10:19:16Z

packages/plasma-icons/src/scalable/Icon.assets.16/Work.tsx

+    <svg width="100%" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
+        <path
+            fillRule="evenodd"
+            clipRule="evenodd"


neretin-trike requested a review from OgNellis as a code owner March 28, 2022 11:19

neretin-trike changed the title ~~feat(plasma-icon): Add icons for 16 dp~~ feat(plasma-icons): Add icons for 16 dp Mar 29, 2022

neretin-trike force-pushed the icon-export-q9spmub4kgg branch from 904dc75 to 80be434 Compare March 30, 2022 06:21

neretin-trike force-pushed the icon-export-q9spmub4kgg branch from 80be434 to 2ea3993 Compare March 30, 2022 12:54

neretin-trike requested review from Yeti-or, fanisco, LamaEats, kvpolyanskiy and VladislavPetyukevich as code owners March 30, 2022 12:54

neretin-trike added the v2.0 label Mar 30, 2022

neretin-trike added 2 commits April 4, 2022 16:09

feat(plasma-icons): Add icons for 16 dp

b547e96

feat(demo-canvas-app): Add scalable icons demo

802dcb3

neretin-trike force-pushed the icon-export-q9spmub4kgg branch from 2ea3993 to 802dcb3 Compare April 4, 2022 09:10

Yeti-or reviewed Apr 11, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plasma-icons): Add icons for `16 dp` #1162

feat(plasma-icons): Add icons for `16 dp` #1162

neretin-trike commented Mar 28, 2022 •

edited by SberDevices-Eva

Loading

codecov bot commented Mar 28, 2022 •

edited

Loading

SberDevices-Eva commented Mar 29, 2022

SberDevices-Eva commented Mar 29, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Apr 4, 2022

SberDevices-Eva commented Apr 4, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022

Yeti-or Apr 11, 2022


		import { IconProps } from '../IconRoot';

		export const Volume1: React.FC<IconProps> = (props) => (

feat(plasma-icons): Add icons for 16 dp #1162

Are you sure you want to change the base?

feat(plasma-icons): Add icons for 16 dp #1162

Conversation

neretin-trike commented Mar 28, 2022 • edited by SberDevices-Eva Loading

codecov bot commented Mar 28, 2022 • edited Loading

Codecov Report

SberDevices-Eva commented Mar 29, 2022

SberDevices-Eva commented Mar 29, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Mar 30, 2022

SberDevices-Eva commented Apr 4, 2022

SberDevices-Eva commented Apr 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat(plasma-icons): Add icons for `16 dp` #1162

feat(plasma-icons): Add icons for `16 dp` #1162

neretin-trike commented Mar 28, 2022 •

edited by SberDevices-Eva

Loading

codecov bot commented Mar 28, 2022 •

edited

Loading