Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #263: add default editor settings #264

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

ScriptSathi
Copy link
Contributor

resolve #263

This feature adds the possibility to define a default text editor other than the default defined in the code.

@ScriptSathi ScriptSathi changed the title resolve #263 : add default editor settings feature (https://github.com/sbstp/kubie/issues/263) : add default editor settings Sep 4, 2024
@ScriptSathi ScriptSathi changed the title feature (https://github.com/sbstp/kubie/issues/263) : add default editor settings feature #263: add default editor settings Sep 4, 2024
@ScriptSathi
Copy link
Contributor Author

Hello @sbstp, I took the liberty to make this tiny feature. What do you think ?

@sbstp
Copy link
Owner

sbstp commented Sep 5, 2024

It's a good idea, however I think setting the default_editor in the config should take precedence over the EDITOR environment variable.

README.md Outdated Show resolved Hide resolved
@ScriptSathi ScriptSathi force-pushed the master branch 2 times, most recently from 6463bc4 to d7a657a Compare September 5, 2024 10:30
@ScriptSathi
Copy link
Contributor Author

This should be better 👌

@sbstp sbstp merged commit 4f741b2 into sbstp:master Sep 11, 2024
5 checks passed
@sbstp
Copy link
Owner

sbstp commented Sep 11, 2024

Thanks, I'll do a release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request : Add a way to define a default text editor for edit/edit-config commands
2 participants