-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shipping log section with the last 3 posts from the blog #97
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/react-app/pages/index.jsx
Outdated
@@ -64,6 +68,7 @@ export default function Index({ bgStats, events }) { | |||
export async function getStaticProps() { | |||
const stats = await getStats(); | |||
const events = await getAllEvents(null, 10); | |||
const posts = await fetchRecentPosts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe get
is more consistent than fetch
:D
Thanks for experimenting with this @Pabl0cks !! Just a general comment about this section: I don't think it adds much value as it's displayed right now. The title & picture are almost the same on every post, it just changes the description a bit, so I don't really see the point of the section itself. Like for me, A more valuable section will be something like:
What do you all think? Maybe this is something we should have talked before, but I personally didn't pay much attention to it when Andrea sent it, since I was focused in the other parts. Sorryt! (Note: the Vercel deployment won't work since the backend is deployed on GAE) |
TYSM @Pabl0cks !! Really nice work !!
Visually I think it looks great, but totally agree with these points and makes more sense to have single section highlighting the main things |
Thank you for the feedback! 🙌♥
💯 Agree, cards feels too repetitive with their current content. Will talk with Andrea to create a new version of the section. |
Thanks Andrea!
Started working yesterday on this. I'm afraid it won't be possible to tweak styles from Substack (there are some technical limitations with <iframe> styling when you are loading external websites, if I understood correctly from link1 or link2) So 2nd option seem the best to me too, since we won't be able to get rid of the watermark and legal notice. Haven't pushed the changes, still working on the RWD. This is how it's looking on laptop: The problem is since I can't change embedded background, in dark mode it must be white also 😬 What do you think about that? Should we skip adding the embedded subscribe widget? |
Hey, sorry for the late reply I agree in that case that design is the best option, to me it looks very good in light mode. But what would be the other option if we want to avoid the dark mode problem? To have our own button instead of the widget + that takes you to the substack page? Also curious to know others opinions :) |
Yeah! 😥 Probably a button with a CTA to go to substack to subscribe. "Subscribe in Substack", "Open Substack" or something similar. |
Yeah, it's a pity but I guess that's the best option if we can't solve the dark mode issue.. Otherwise it's a bit weird that only that section stays in white no? To me 'Subscribe in Substack' or just 'Subscribe' is good for the button 🙌🏻 |
Had to build the widget for it, tried to follow the same logic to fetch the data and style it with Chakra.
A couple of notes:
We could also add a subscribe widget from substack below the posts if we see it interesting:
Screenshots: