Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null value in bitbucket API response for repository #3150

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

jduval87
Copy link

@jduval87 jduval87 commented Aug 28, 2023

As pointed out in issue #3143 it looks like bitbucket cloud API has started to emit null jsvalue which break the circe custom decoder for RepositoryResponse.

The proposed solution is a bit naive. And I hacked a test around with what is already available.

Feel free to edit.

@jduval87 jduval87 marked this pull request as ready for review August 28, 2023 14:31
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (2226165) 91.03% compared to head (ef2304f) 91.07%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3150      +/-   ##
==========================================
+ Coverage   91.03%   91.07%   +0.03%     
==========================================
  Files         162      163       +1     
  Lines        3404     3406       +2     
  Branches      321      284      -37     
==========================================
+ Hits         3099     3102       +3     
+ Misses        305      304       -1     
Files Changed Coverage Δ
...ward/core/forge/bitbucket/RepositoryResponse.scala 87.50% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzvara
Copy link
Contributor

zzvara commented Sep 9, 2023

Scala Steward has failed ever since on Bitbucket Cloud. Could someone merge this PR? <3

Copy link
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jduval87! And sorry it took so long, I approved the CI and forgot to come back later on 😓

@alejandrohdezma alejandrohdezma merged commit caf5902 into scala-steward-org:main Sep 10, 2023
6 checks passed
@mzuehlke mzuehlke added cat:forge bug Something isn't working labels Sep 17, 2023
@mzuehlke mzuehlke added this to the 0.26.0 milestone Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cat:forge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants