Skip to content

Present scala 2 if syntax #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2022
Merged

Present scala 2 if syntax #2284

merged 4 commits into from
Jan 3, 2022

Conversation

aresen
Copy link
Contributor

@aresen aresen commented Jan 3, 2022

Added scala 2 if syntax as an example in comparison to scala 3

Mentioned in #2216

julienrf
julienrf reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good to me! I suggest that we repeat, in the code snippets, that we are using Scala 2 syntax. What do you think?

aresen and others added 2 commits January 3, 2022 08:41
@aresen @julienrf
Specify Scala 2 in if snippet
cbc6d00 
Co-authored-by: Julien Richard-Foy <[email protected]>
@aresen @julienrf
Specify Scala 2 in for statement
4aade2c 
Co-authored-by: Julien Richard-Foy <[email protected]>
@julienrf julienrf merged commit 646f66a into scala:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aresen @julienrf