Skip to content

Add code tabs for scala3-book/taste-repl #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Conversation

byyue
Copy link
Contributor

@byyue byyue commented Aug 5, 2022

See #2481:
Scala 3 Book -> A Taste of Scala -> The REPL.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! The suggestions I made are just to make it more maintainable

@byyue
Copy link
Contributor Author

byyue commented Aug 6, 2022

Thank you for the review! I have another thought: to set the Scala 3 tab as the default, at least in the Scala 3 Book. That's why I put it before the Scala 2 tab.

image

@julienrf Do you consider it wise to unify this kind of format?

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me personally numbers ascending left to right across the tabs makes sense, but maybe others would object - but if we chose to change the convention then that should be done globally across the site in a separate PR.

As time goes on we will likely rebrand the book to just the Scala Book when we have updated enough code examples

@byyue byyue requested a review from bishabosha August 9, 2022 11:04
@bishabosha bishabosha merged commit 011d86e into scala:main Aug 9, 2022
@bishabosha
Copy link
Member

Thanks a lot!

@byyue byyue deleted the dev-2481 branch August 10, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants