-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code tabs for scala3-book/taste-repl #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! The suggestions I made are just to make it more maintainable
Co-authored-by: Jamie Thompson <[email protected]>
Co-authored-by: Jamie Thompson <[email protected]>
Thank you for the review! I have another thought: to set the Scala 3 tab as the default, at least in the Scala 3 Book. That's why I put it before the Scala 2 tab. @julienrf Do you consider it wise to unify this kind of format? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me personally numbers ascending left to right across the tabs makes sense, but maybe others would object - but if we chose to change the convention then that should be done globally across the site in a separate PR.
As time goes on we will likely rebrand the book to just the Scala Book when we have updated enough code examples
Thanks a lot! |
See #2481:
Scala 3 Book -> A Taste of Scala -> The REPL.