boundary/break expression plus several examples of custom control structures
#3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkepka
commented
Nov 18, 2024
| {% endtab %} | ||
| {% endtabs %} | ||
|
|
||
| Since `break` uses an exception to control the execution flow, mixing it with `try`/`catch` can lead to unexpected results: |
There was a problem hiding this comment.
This one looks like a potential huge footgun if someone doesn't notice break throws an exception, so I wanted to mention it. Please notify if the try/catch example is OK and should stay.
There was a problem hiding this comment.
Try also swallows the control flow because internally it uses try/catch in a non-boundary/break compatible way. It might also be worth explaining how to avoid catching it. (E.g. case e: Exception if !e.isInstanceOf[Break[?]].)
gkepka
commented
Nov 18, 2024
Comment on lines
+1123
to
+1124
| The following example uses a context parameter to store actions to be executed after a block of code is completed. The | ||
| `with_defer` function defines a scope in which `defer` can be used to defer execution of actions. |
There was a problem hiding this comment.
Not sure about this because context parameters are not mentioned yet at this point. Maybe the custom control structures section should be moved to a separate page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.