Skip to content

Fix #11654: disable pickling test for language.scala #11666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

liufengyun
Copy link
Contributor

Fix #11654: disable pickling test for language.scala

This is a quick fix to the CI. We still need time to get to the bottom of the issue on Windows.

[test_windows_full]

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but remove "Fix" from the commit message or make sure to re-open the issue after merging this.

@liufengyun
Copy link
Contributor Author

LGTM, but remove "Fix" from the commit message or make sure to re-open the issue after merging this.

Thanks, I'd re-open the issue, so we can save some cycles in CI.

@liufengyun liufengyun requested a review from smarter March 15, 2021 09:44
@smarter smarter merged commit 4ffc548 into scala:master Mar 15, 2021
@smarter smarter deleted the fix-11654 branch March 15, 2021 11:19
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_windows_full in the CI is broken: pickling difference in stdlibPatches
3 participants